feat: move credentials to .env file instead of writing them in plain text (#DVRL-71)#716
feat: move credentials to .env file instead of writing them in plain text (#DVRL-71)#716JohannesDienst-askui wants to merge 5 commits intomainfrom
Conversation
|
Great job! 💪 |
Ah ok. My ticket said I should implement this, or at least I understood it that way 😉 I would like to install the |
Personally, I don't like shipping it like that. However, I would advise waiting for @programminx-askui. You can discuss it with him, and he can then bring it up with @dom-askui. I can't decide for the team. |
|
Moved the docs part to askui/askui-dev-docs#10 |
We stored the credentials (workspace-id + access token) in
helpers/askui-helpers.tsin plain text. While this is ok for local projects, it increases the risk of pushing credentials into a repository and exposing them.This PR moves the credentials into
.envwhere they are usually excluded with a proper.gitignoreminimizing the risk of of leaking credentials 🥳 .